Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit FormData error events as Request error events #1341

Merged
merged 5 commits into from Jan 9, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions request.js
Expand Up @@ -1428,6 +1428,11 @@ Request.prototype.form = function (form) {
}
// create form-data object
self._form = new FormData()
self._form.on('error',function(err) {
err.message = 'form-data: ' + err.message
self.emit('error', err)
self.abort()
})
return self._form
}
Request.prototype.multipart = function (multipart) {
Expand Down
34 changes: 34 additions & 0 deletions tests/test-form-data-error.js
@@ -0,0 +1,34 @@
'use strict'

var request = require('../index')
, server = require('./server')
, tape = require('tape')

var s = server.createServer()

tape('setup', function(t) {
s.listen(s.port, function() {
t.end()
})
})

tape('re-emit formData errors', function(t) {
s.on('/', function(req, res) {
res.writeHead(400)
res.end()
t.fail('The form-data error did not abort the request.')
})

request.post(s.url, function (err, res, body) {
t.equal(err.message, 'form-data: Arrays are not supported.')
setTimeout(function() {
t.end()
}, 10)
}).form().append('field', ['value1', 'value2'])
})

tape('cleanup', function(t) {
s.close(function() {
t.end()
})
})