Add missing HTTPS options that were not being passed to tunnel (@brichard19) #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added test cases in test-tunnel.js
… pr-1380-reroll
|
@seanstrom @simov @FredKSchott review pls? |
|
This seems okay, I believe this has been reviewed throughly else-where correct? |
|
not sure about that, it's a pretty simple change though, and it includes a decent test case. |
|
ill give another look over today, then ill merge |
|
merging and releasing new version |
nylen
added a commit
that referenced
this pull request
Feb 2, 2015
Add missing HTTPS options that were not being passed to tunnel (@brichard19)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-roll of #1380 with lint issues fixed and a few other cleanups. It passes more special HTTPS options to the tunnel, but there is more work needed after this: we still have to do some special stuff to get HTTPS tunnels and destinations to use a custom certificate authority. We will probably need to modify
tunnel-agentin the future to fix this.I'd like to release a new version after this change gets through, it has been a while and we have a couple of fixes that people have requested.