Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up debug code #1387

Closed
wants to merge 1 commit into from
Closed

Clean up debug code #1387

wants to merge 1 commit into from

Conversation

nylen
Copy link
Member

@nylen nylen commented Jan 29, 2015

Make debug a prototype method. This has a couple of advantages:

Make debug a prototype method.  This has a couple of advantages:

- It's no longer necessary for the debug code to be at a specific place
  in request.js, see request#1354
- It's easier for helper methods in other files to generate debug
  messages, see request#1360
@nylen nylen closed this Feb 4, 2015
@simov
Copy link
Member

simov commented Feb 5, 2015

@nylen with this changes #1407 we'll be able to add the debug code as you proposed. We can then access it like

request.debug()

inside each method. All of the debug calls are currently commented out in #1407 so you can easily find them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants