Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to set a requester without setting default options #1436

Merged
merged 1 commit into from Feb 19, 2015
Merged

Add ability to set a requester without setting default options #1436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions index.js
View file
Open in desktop
Expand Up @@ -99,6 +99,12 @@ request.cookie = function (str) {
}

request.defaults = function (options, requester) {

if (typeof options === 'function') {
requester = options
options = {}
}

var self = this
var wrap = function (method) {
var headerlessOptions = function (options) {
Expand Down
17 changes: 17 additions & 0 deletions tests/test-defaults.js
View file
Open in desktop
Expand Up @@ -266,6 +266,23 @@ tape('test custom request handler function', function(t) {
})
})

tape('test custom request handler function without options', function(t) {
t.plan(1)

var customHandlerWithoutOptions = request.defaults(function(uri, options, callback) {
var params = request.initParams(uri, options, callback)
var headers = params.options.headers || {}
headers.x = 'y'
headers.foo = 'bar'
params.options.headers = headers
return request(params.uri, params.options, params.callback)
})

customHandlerWithoutOptions.get(s.url + '/get_custom', function(e, r, b) {
t.equal(e, null)
})
})

tape('test only setting undefined properties', function(t) {
request.defaults({
method: 'post',
Expand Down