Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stall when piping gzipped response #1568

Merged
merged 1 commit into from May 8, 2015

Commits on May 8, 2015

  1. Pause/Resume response content, not response

    When the response content is piped through additional streams for
    decoding (e.g. for gzip decompression), pause and resume calls should be
    propagated to the last stream in the pipeline so that back pressure
    propagates correctly.
    
    This avoids an issue where simultaneous back pressure from the content
    decoding stream and from a stream to which Request is piped could cause
    the response stream to get stuck waiting for a drain event on the
    content decoding stream which never occurs.  See request#1567 for an example.
    
    This commit also renames dataStream to responseContent to remedy my
    previous poor choice of name, since the name will be exposed on the
    Request instance it should be clearer and closer to the name used to
    refer to this data in the relevant RFCs.
    
    Fixes request#1567
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
    kevinoid committed May 8, 2015
    Copy the full SHA
    bd3d3ad View commit details
    Browse the repository at this point in the history