Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pause before response arrives #1569

Merged
merged 1 commit into from May 11, 2015
Merged

Commits on May 8, 2015

  1. Fix pause before response arrives

    Due to request#1568, we now propagate pause and resume to the response content
    stream, rather than the response stream.  However, when pause is called
    before the response arrives, the pause is still being applied to the
    response object directly.  Fix this by applying it to the response
    content stream in both cases.  This avoids the issue that if pause is
    called on a gzip request before the response arrives, it pauses the
    response then resumes the response content, meaning the response can not
    be resumed.
    
    Also add tests of the pause/resume behavior for both the gzip and
    non-gzip case both before and after the response has arrived.
    
    This commit also makes the ancillary change that resume is now called
    unconditionally (when defined) in Redirect, since we always want to
    dump the response data (and it was previously called unconditionally in
    onRequestResponse).
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
    kevinoid committed May 8, 2015
    Copy the full SHA
    e43218d View commit details
    Browse the repository at this point in the history