Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for forever-agent PR #29 - Enable socket reuse #1575

Closed
wants to merge 2 commits into from

Conversation

mgorczyca
Copy link

Added as requested by @simov

@mgorczyca
Copy link
Author

Looks like the error is that the test failed. The forever-agent PR #29 is needed for the test to succeed.

@simov
Copy link
Member

simov commented May 14, 2015

@mgorczyca thanks for your input. However your test is failing only on 0.10, and it is passing with 0.12 and io.js without applying your fix from the forever-agent repo. The error you are seeing in TravisCI is that the next test is timing out, which is completely different issue. Just skip the next test tape.skip and run tape tests/test-agent.js with both 0.12 and iojs - you'll see that your test is passing, so I'm not sure what exactly it tests.

@mgorczyca
Copy link
Author

Thanks for your feedback @simov. I thought I had run my test in a pure 0.12 environment, and discovered one override to 0.10. I originally discovered the problem in 0.10 where the test still (properly) fails. Once I corrected my 0.12 environment, the test passes there for me, just as it does for you. We are planning to use 0.12 at this point, so we can close the issue and the PR if you agree that is best.

@simov
Copy link
Member

simov commented Jul 19, 2015

Closing in favor of #1671 - request now defaults to http(s).Agent in node 0.12+ when the forever option is used.

@simov simov closed this Jul 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants