Fix OAuth query transport_method #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve OAuth transport_method related tests
simov
added a commit
that referenced
this pull request
Jun 11, 2015
Fix OAuth query transport_method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke it here simov@4131904#diff-84fad1d3b3913ec86805e857580c5d54R114 because the OAuth parameters were appended here simov@4131904#diff-ccc0734f65dd7a299409ff07d35be095L1398 instead of replaced.
Additionally now
request.uriis constructed properly when using OAuthtransport_method:query, so when usingrequest-debugthe correcturiis dumped containing all of the query parameters.Lastly I greatly improved the OAuth transport_method related tests, because they were a bit loose and the cause of this bug in the first place.