Use the extend module to deep extend when using the defaults method
#1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simov
added a commit
that referenced
this pull request
Jun 15, 2015
Use the `extend` module to deep extend in the defaults method
|
when using npm install request (2.6.4), it throws cannot find module extend,after install it manually (3.0) , it works ok. don't know this is a error caused by npm or something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikeal @nylen I'm introducing the extend module into core. This fixes the flat extend behavior when using
util._extendindefaultsfor any other object key that theheaders.Let me know what do you think.