Set certificate expiration to August 2, 2018 #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the gen-* scripts to take a `-days` argument, and set that `days` argument to 3 years from now. I believe without this argument the certificates default to a 30 day expiry. Code lifted from https://github.com/shazow/urllib3/blob/master/dummyserver/certs/README.rst. Generates new SSL certs with a long expiry.
|
whoops... need to check if this passes tests. 1 minute. |
|
Something isn't right with our tests lately, it's on my TODO list to investigate why they timeout so badly on TravisCI. |
|
When I opened the PR the branches hung on |
simov
added a commit
that referenced
this pull request
Aug 3, 2015
Set certificate expiration to August 2, 2018
|
Thanks, now you can pull master 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the gen-* scripts to take a
-daysargument, and set thatdaysargument to 3 years from now. I believe without this argument the certificates
default to a 30 day expiry. Code lifted from
https://github.com/shazow/urllib3/blob/master/dummyserver/certs/README.rst.
Generates new SSL certs with a long expiry.