Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hawk to version 4.0.0 πŸš€ #1891

Closed
wants to merge 1 commit into from

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello πŸ‘‹

πŸš€πŸš€πŸš€

hawk just published its new version 4.0.0, which is not covered by your current version range.

If this pull request passes your tests you can publish your software with the latest version of hawk – otherwise use this branch to work on adaptions and fixes.

Happy fixing and merging 🌴


The new version differs by 7 commits .

See the full diff.


This pull request was created by greenkeeper.io.
It keeps your software, up to date, all the time.

Tired of seeing this sponsor message? Upgrade to the supporter plan! You'll also get your pull requests faster ⚑

@simov
Copy link
Member

simov commented Nov 6, 2015

On hold until we drop support for everything below 4.0.0 https://twitter.com/eranhammer/status/662013345550065664

@joeycozza
Copy link

Hawk@4.1.1 would solve the Node Security Advisory that has just recently been released.

@simov
Copy link
Member

simov commented Jan 21, 2016

The Node Security Advisory 77 was fixed for hawk@3.1.3 as well so you and your code are protected. Not to mention that the fix was about the server implementation of hawk, not the client one.

Resources:

I'm going to use this comment as references to any new PR about this issue. If you have problems with warning messages about this security issue, contact the authors of that tool to update their database.

@ralphtheninja
Copy link

The Node Security Advisory 77 was fixed for hawk@3.1.3 as well so you and your code are protected. Not to mention that the fix was about the server implementation of hawk, not the client one.

@simov Thanks! What's the process of updating nsp to not report on false positives?

@simov
Copy link
Member

simov commented Jan 22, 2016

No idea TBH, I guess they (https://github.com/nodesecurity/nsp) should support things like:

Patched: >=3.1.3 || >=4.1.1

but I'm not sure.

@evilpacket
Copy link

I'm updating the advisory to reflect the correct semver versions right now.

@mikeal mikeal force-pushed the greenkeeper-hawk-4.0.0 branch 4 times, most recently from 3509ed8 to 3c51968 Compare July 13, 2016 20:41
@simov
Copy link
Member

simov commented Aug 28, 2016

#2353

@simov simov closed this Aug 28, 2016
@simov simov deleted the greenkeeper-hawk-4.0.0 branch August 28, 2016 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants