Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IncomingMessage.destroy method #1958

Merged
merged 1 commit into from Dec 12, 2015
Merged

Conversation

simov
Copy link
Member

@simov simov commented Dec 10, 2015

Not documented public method: nodejs/node#4226

There is no abort method and this causes some issues here: #1953

Also not covered by our tests: https://codecov.io/github/request/request/request.js?ref=23fa4417ced5ee53105aef9a5c5a3f9fd56c3f9b#l-1047

Fixes #1588
Closes #1953

simov added a commit that referenced this pull request Dec 12, 2015
Use IncomingMessage.destroy method
@simov simov merged commit 29fca98 into request:master Dec 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant