Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TravisCI badge reference master branch #2167

Merged
merged 1 commit into from Apr 14, 2016
Merged

Conversation

a0viedo
Copy link
Contributor

@a0viedo a0viedo commented Apr 13, 2016

I also noticed there're two badges for Coverage, one pointing to Codecov and the other one to Coveralls. Is this intended or one should not be used?

@simov
Copy link
Member

simov commented Apr 13, 2016

I guess that was the reason why the icons was stuck on build error?

Yes we need both of those coverage badges. Coveralls was not showing up the file coverage at some point, something was bugged out with the request repo. We tried just about everything and the issue is still open and not resolved on the Coveralls issue tracker.

@simov simov changed the title make travisci badge reference master branch Fix TravisCI badge reference master branch Apr 14, 2016
@simov simov merged commit 579c111 into request:master Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants