Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'delete' alias for the 'del' API method #2175

Merged
merged 2 commits into from Apr 16, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
Expand Up @@ -888,12 +888,13 @@ Same as `request()`, but defaults to `method: "HEAD"`.
request.head(url)
```

### request.del
### request.del / request.delete

Same as `request()`, but defaults to `method: "DELETE"`.

```js
request.del(url)
request.delete(url)
```

### request.get
Expand Down
9 changes: 5 additions & 4 deletions index.js
Expand Up @@ -56,7 +56,7 @@ function request (uri, options, callback) {
}

function verbFunc (verb) {
var method = verb === 'del' ? 'DELETE' : verb.toUpperCase()
var method = verb.toUpperCase()
return function (uri, options, callback) {
var params = initParams(uri, options, callback)
params.method = method
Expand All @@ -70,7 +70,8 @@ request.head = verbFunc('head')
request.post = verbFunc('post')
request.put = verbFunc('put')
request.patch = verbFunc('patch')
request.del = verbFunc('del')
request.del = verbFunc('delete')
request['delete'] = verbFunc('delete')

request.jar = function (store) {
return cookies.jar(store)
Expand All @@ -91,7 +92,7 @@ function wrapRequestMethod (method, options, requester, verb) {
target.pool = params.pool || options.pool

if (verb) {
target.method = (verb === 'del' ? 'DELETE' : verb.toUpperCase())
target.method = verb.toUpperCase()
}

if (isFunction(requester)) {
Expand All @@ -114,7 +115,7 @@ request.defaults = function (options, requester) {

var defaults = wrapRequestMethod(self, options, requester)

var verbs = ['get', 'head', 'post', 'put', 'patch', 'del']
var verbs = ['get', 'head', 'post', 'put', 'patch', 'del', 'delete']
verbs.forEach(function(verb) {
defaults[verb] = wrapRequestMethod(self[verb], options, requester, verb)
})
Expand Down
11 changes: 11 additions & 0 deletions tests/test-defaults.js
Expand Up @@ -138,6 +138,17 @@ tape('del(string, function)', function(t) {
})
})

tape('delete(string, function)', function(t) {
request.defaults({
headers: {foo: 'bar'},
json: true
}).delete(s.url + '/', function (e, r, b) {
t.equal(b.method, 'DELETE')
t.equal(b.headers.foo, 'bar')
t.end()
})
})

tape('head(object, function)', function(t) {
request.defaults({
headers: { foo: 'bar' }
Expand Down