Remove connectionErrorHandler to fix #1903 #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simov This PR fixes the simple repro I posted in #1903 (comment), which I believe to be representative of the real-world cases people are hitting (e.g. failures in npm). |
|
Version 2.73 is published with the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "socket._httpMessage.emit('error', error)" line currently throws when the keep-alive period expires and the socket resets, after a redirect to a different host. This is because the listener on the socket is never cleaned up, and the socket no longer has _httpMessage (the ClientRequest is long gone). This is bug #1903, which is also responsible for npm/npm#9984.
It looks to me like node core correctly re-emits socket error events on _httpMessage now, so we shouldn't have to. Looking at core I also cannot even find a "res" property on socket - if there's a reason to leave this, please speak up.
Closes #1903