Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix target.method of defaults.del #2249

Closed
wants to merge 1 commit into from
Closed

Fix target.method of defaults.del #2249

wants to merge 1 commit into from

Conversation

katemihalikova
Copy link

target.method is set to DEL instead of DELETE in defaults.del.

Introduced in #2175 (2ef974a), broken since 2.72.0.

@codecov-io
Copy link

codecov-io commented Jun 17, 2016

Current coverage is 91.18%

Merging #2249 into master will increase coverage by <.01%

@@             master      #2249   diff @@
==========================================
  Files            12         12          
  Lines          1417       1418     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1292       1293     +1   
  Misses          125        125          
  Partials          0          0          

Powered by Codecov. Last updated by 1b19c88...e605c4d

@simov
Copy link
Member

simov commented Jun 17, 2016

Hi @katemihalikova can you add a failing test for this?

@katemihalikova
Copy link
Author

After more investigation it turned out that even though here target.method is set to DEL it is later replaced with DELETE here. The original problem was found in our own codebase, not in request. Thanks anyway.

@katemihalikova katemihalikova deleted the fix/del branch June 21, 2016 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants