Update tough-cookie to version 2.3.0 🚀 #2294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to this -- NSP just published a vulnerability in tough-cookie < 2.3.0 https://nodesecurity.io/advisories/130 |
|
Closing in favor of #2295 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
tough-cookie just published its new version 2.3.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of tough-cookie.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 13 commits .
5d155792.3.06156272Merge pull request #68 from SalesforceEng/fix-too-many-semicolonse4fc2e0Reduce parse time for many semicolons.ce76918Test on 4.4 until Travis supports --lts72820beSupport 4.0 (minimum), lts, and stable43dc0d6Merge pull request #65 from ide/patch-11fbeb07Add links to 3rd party stores to the READMEcc466282.2.2a44dcfeMerge pull request #64 from iamstolis/issue-63e2849beSimplification of (LOOSE_)COOKIE_PAIR regular expressions.f1055652.2.19348551Merge pull request #58 from SalesforceEng/fix-5792cfee7Move aliasing of deserializeSync below definitionSee the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade