Fix socket 'connect' listener handling #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
force-pushed
the
fix-timeout-regression
branch
from
bc15d2b
to
8616467
Compare
|
@mdlavin Ok, I've updated it to remove the handler on |
|
I'll redeploy with the new version and watch memory again |
mscdex
force-pushed
the
fix-timeout-regression
branch
from
8616467
to
b96813a
Compare
mscdex
force-pushed
the
fix-timeout-regression
branch
3 times, most recently
from
a158176
to
8d139f7
Compare
mscdex
changed the title
This commit ensures that both a 'connect' timer only starts when a new socket is being used for a request and that the 'connect' timer is stopped in more places. Fixes: request#2438
mscdex
force-pushed
the
fix-timeout-regression
branch
from
8d139f7
to
001eae3
Compare
|
Ack, you were too fast with merging, I was going to make another change yet. I will open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2438
/cc @mdlavin Can you try this patch?