Always set request timeout on keep-alive connections #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can publish another patch no problem, I had to ask you first. So is this good for merging/publishing? |
mscdex
force-pushed
the
fix-timeout-regression
branch
2 times, most recently
from
1c27101
to
910d710
Compare
001eae3 would erroneously only set http request timeout if a new socket was being used for the request. This commit ensures the http request timeout is always set, even on keep-alive connections.
mscdex
force-pushed
the
fix-timeout-regression
branch
from
910d710
to
82da8b8
Compare
|
It should be good to go now, I've added a test for it. |
|
Thank you! Published. |
pulkitsinghal
added a commit
to ShoppinPal/vend-nodejs-sdk
that referenced
this pull request
Sep 15, 2017
## Motivation - Some upstream projects that use `vend-nodejs-sdk` were facing strange issues where long-running use (after 47 minutes or so) led so a situation where nodejs would just hang after a POST request. - There weren't any clear CPU or Memory consumption red flags. - It seemed more like a bad promise chain or failing to invoke a callback that often leads nodejs into a forever running state and there's nothing really going on. ## Solution Look at the [CHANGELOG](https://github.com/request/request/blob/master/CHANGELOG.md) for `request` and see if any plausible reasons for trying a module update. 1. request/request#2431 2. request/request#2414 3. request/request#2447 4. request/request#2448 This wasn't an exact science but their descriptions seemed to merit the dependency upgrade as "at least worth a try" ## Consequences Dropped support for Node 0.10 request/request#2381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.