fixes for redirect not preserving body with followOriginalHttpMethod #2608

[tpae]

This PR fixes #2608.

Problem occurs when setting followOriginalHttpMethod to true, request body is not preserved and is not passed with the redirect.

Steps to reproduce is outlined by @mirkods in #2608. I've added additional cases to verify the changes. It should be a minimal change, with very little impact.

PR Checklist:

• I have run npm test locally and all tests are passing.
• I have added/updated tests for any new behavior.
  
• If this is a significant change, an issue has already been created where the problem / solution was discussed: Redirect with followOriginalHttpMethod:true does not mantain the original body #2608
  

PR Description

I modified redirect logic to preserve body, content type, and content length when followOriginalHttpMethod is set to true.

[mirkods]

Well done @tpae, hope it will be merged soon!

[mirkods]

Guys any news on this?

[tpae]

Not sure. I ended up switching to axios

[Lorenzovds]

@mikeal could we get this merged? 😄

[siddhuwarrier]

Hey guys, hello from Cisco Meraki, and we're running into the same issue with Cisco-internal integrations! Getting this PR merged would be amazing, as with this HTTP 308 will behave according to specification. :-)

[codenirvana]

@tpae I feel this feature(support for 308 Permanent Redirect) should be independent offollowOriginalHttpMethod option. It should be handled by default(as per RFC) just like 307.
A possible side effect of this implementation will be, the body will be sent even for non 307 or 308 redirects which violate the RFC.

I fixed this in our fork recently.

However, there's another issue which you will face i.e, FormData bodies are lost on redirection.
So, I reinitialize the request._form stream which works for text and file form values but it drops other streams(request, http etc).

cc. @reconbot @mikeal

[pkuczaj]

Any progress on the decision to merge this PR?