feat(aws): allow service and region to be specified in aws options. #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
apologies. I did run tests locally, but there appears to be a problem. I'm looking into it. |
|
There we go! |
elliotttf
reviewed
Aug 16, 2017
| @@ -1364,6 +1364,8 @@ Request.prototype.aws = function (opts, now) { | |||
| host: self.uri.host, | |||
| path: self.uri.path, | |||
| method: self.method, | |||
| service: opts.service, | |||
There was a problem hiding this comment.
Is it expected that custom domains would only be available for version 4 signing?
There was a problem hiding this comment.
I'm not positive what service and region might be used for other than API Gateway. API Gateway only supports version 4 though.
|
👍 for merging this, working around it currently. |
|
When can we get this merged? we need 'region' to sign AWS API Gateway url with custom DNS |
|
When this will be merged? I need to sign4 request to API Gateway, and the service param is needed to create the signature. |
|
Please merge |
|
we need this feature. Please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
npm testlocally and all tests are passing.PR Description
This PR picks up where #2188 and #2339 left off to allow aws signing for API Gateway requests which require service and region as part of the signature. aws4 supports adding both
serviceandregionso this is a simple change.Many thanks to @NewGyu who originally wrote this code which I've simply applied to the latest master!