Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unixsocket when url contains colon #2915

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

willkan
Copy link

@willkan willkan commented Apr 18, 2018

PR Checklist:

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

There is a bug when request unix url with search which contains :. This pr is expecting to fix this bug.

for example http://unix:/absolute/path/to/unix.socket:/request/path?x=a:b, will only send http://unix:/absolute/path/to/unix.socket:/request/path?x=a to the unix socket server

@willkan
Copy link
Author

willkan commented Jul 17, 2018

merge from the new master.

@willkan
Copy link
Author

willkan commented Jul 17, 2018

@mikeal could u check this pr and merge it if it is ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants