-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from Travis to GitHub Actions #470
Conversation
I tested AndreMiras/coveralls-python-action, but found out important issue here AndreMiras/coveralls-python-action#13 Coverage is passing and multiple github checks are added to the report, which is good. However, the data is pushed to coveralls as a "new coverage", i.e. we don't know if the coverage has increased or decreased compared to the master branch (base). I will move back to coverallsapp/github-action@master which was requiring a lcov format and not a standard format that coverage produce. |
This reverts commit 3d61653.
So with the AndreMiras/coveralls-python-action I get https://coveralls.io/builds/44520842. When using the official coverallsapp/github-action I get https://coveralls.io/builds/44524845. |
Would the coverage comparison data not be shown if opening the "COVERAGE CHANGED" tab? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also inject a small doc/setup/getting started readme, specifically with the tox
tool. I messed around with it for a while and could only get py2.7 stuff to work. I'm sure I'm screwing something up with the setup on my end.
UPDATE
So for potential documentation, I found that running tox -e <python-version-youre-working-with>
simplifiled the local replication process. Also when running manually, be sure to install both requirements files (there are three, depends on which version of python you're running in venv) ... pip install -r requirements.txt && pip install -r requirements-test.txt
AND pip install coveralls coverage-lcov toml
I think we can safetly add the following dependencies in
|
Co-authored-by: Jacques Troussard <jacques.troussard@gmail.com>
I have added a contributing guide, can you verify? Thanks! |
I'm parking the coverage question as of now, as we will need to see it in action with a couple of PRs to see if we can live with it or not. Anyway it should not be a blocker to start reviewing some PRs. The PR is ready to be merged if review is OK! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
looks good - let's confirm Github actions are working after this merge |
As discussed in #460 and in #469, it seems simpler to use GitHub actions.