Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Issue 1785 - IE11 - Requiring mixed content never resolves or errors #1786

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davedoran
Copy link

#1785

Websites served over HTTPS will refuse to load HTTP urls by default.

While all browsers reject an attempt to require([ 'http://some/module' ]), the timing is different on IE.

IE throws an error when adding the node.src attribute
Other browsers error out when appending the node to the DOM.

In the Chrome/FF/Safari/etc... scenario, the error callback is triggered and the error is reported.
For IE, the script tags are never a part of the DOM and the callbacks for load or error are not invoked. The result is an unhandled exception coming from requirejs and the calling code is never notified of the failure.

The Fix

Try/Catch around the action of adding the node.src, and notify the caller of the script error.

@jsf-clabot
Copy link

jsf-clabot commented Aug 6, 2019

CLA assistant check
All committers have signed the CLA.

@ddziaduch
Copy link

@davedoran the CI has failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants