Issues found by repeated loading/unloading with sometimes failures #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change consists of 2 parts. They are all related to thorough cleanup of residual objects after "undef()" and loading failures. 1. Fix to make timeout fire again in retry after having already fired for a failure to load. 2. Fix to clean up "anonymous" registry entries that had been put there as intermediates after their prerequisites failed to load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am using RequireJS in a project that requires repeatedly loading and unloading modules. I found 2 problems:
I have tested using the given suite on up-to-date Edge, Chrome and Firefox.
Thanks!