Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per contribution guidelines I assume this fork is a one/two line fix.
User story:
In our project we use Chart.js which we defined in paths as "chartjs": "filepath". As You can see the module name is without the dot. But we also need chartjs-adapter-moment which assumes and requires module named 'chart.js'. Currently we forked the chartjs-adapter-moment and made needed change to allow working it with Require.js.
Problem:
Even if there's a 'chart.js' module defined in config.paths it won't work because Require.js assumes 'chart.js' is a file path because of the -.js.
Solution:
If there's module defined in config.paths with -.js inside then use the defined path instead first assuming that it's a js file path. Simply saying: just check first if exact name is defined in config.paths and if not then go with the old way.
If my solution is not good enough please adjust it as You like, but don't ignore the -.js module name problem.