Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: docs-latest push workflow not triggered by release #6366

Merged
merged 4 commits into from
May 21, 2024

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented May 16, 2024

What

release.yml contains a bit of code that force-pushes the release branch into docs-latest, which should then trigger a redeploy of rerun.io together with updated env vars, e.g. RELEASE_VERSION set to the newly released version. That did not happen because the default GITHUB_TOKEN generated by GHA cannot be used to trigger other workflows: https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jprochazk jprochazk added exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels May 16, 2024
@Wumpf Wumpf self-requested a review May 17, 2024 06:42
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emilk emilk merged commit ce3bda3 into main May 21, 2024
30 checks passed
@emilk emilk deleted the jan/fix-docs-latest-trigger branch May 21, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants