Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert making web_viewer a default feature of rerun_py #6370

Merged
merged 1 commit into from
May 20, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 17, 2024

What

In #6335 web_viewer became a default feature of rerun_py.
This caused a bunch of issues for development:

  • pixi run py-build builds with default features and doesn't build new wasm blobs, meaning that the build either fails or picks up outdated
  • currently contributor ci doesn't build the web builder during its wheel test job causing failures

Q: Are we sure that wheel publish would still include the web_viewer?
A: Yes. We test this prior to release. This works because we use the pypi feature of build_and_upload_wheels.py. This script also ensures that the wasm blobs are built.

Q: Why does the non-contributor ci build the wasm blobs?
A: It doesn't! Again, we use build_and_upload_wheels.py there which builds with --no-default-features. However, that script can't be used on the contributor ci since that would spill the GCS secrets (upload on that script is not optional right now).

=> Alternative solutions:

  • do --no-default-features on pixi run py-build and on the contributor ci (potentially by using and adjusting build_and_upload_wheels.py
  • make pixi run py-build slower by making it depend on the web build

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🧑‍💻 dev experience developer experience (excluding CI) 🚢 CI exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 17, 2024
@emilk emilk merged commit 42ff28c into main May 20, 2024
34 of 38 checks passed
@emilk emilk deleted the andreas/undo-webviewer-default-python branch May 20, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants