separate path for archived posts #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cometkim is attempting to deploy a commit to the ReScript Association Team on Vercel. A member of the Team first needs to authorize it. |
The previous approach (tabs) doesn't preserve URL path for archived posts and therefore doesn't provide basic web browsing experiences such as history-back. While improving this, it also removes various duplications used to filter posts. Also, this makes the blog page faster because less initial data is loaded for entry.
fhammerschmidt
requested changes
Apr 21, 2024
fhammerschmidt
approved these changes
Apr 21, 2024
fhammerschmidt
merged commit 961ec72
into
rescript-association:master
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach (tabs) doesn't preserve URL path for archived posts and therefore doesn't provide basic web browsing experiences such as history-back.
While improving this, it also removes various duplications used to filter posts.
Also, this makes the blog page faster because less initial data is loaded for entry.