Hide top nav on reading docs on mobile #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The top navigation disappears when you scroll down and reappears when you scroll up. Like browsers, and many content services like Medium, This is a necessary feature for mobile readers with a small viewport. Also made some code changes here to add memoization, because the scroll event is highly frequant. `React.useState` preserves the reference of the set dispatcher, but doesn't for the surrounding tuple. Adding a few memo, most children, except for components that are cheap to render, are not re-rendered. Also no deep re-render, the appearance state is propagated via old good CSS cascading rather than React state.
|
@cometkim is attempting to deploy a commit to the ReScript Association Team on Vercel. A member of the Team first needs to authorize it. |
Screencast.from.2024-04-21.13-40-11.webm |
|
This works great, nice work! |
|
Ah, the original intention was to add it to the blog, not the API docs 😂 |
|
It now works on API, Docs, and Blog articles. Any other place to need it? |
|
@fhammerschmidt Done. Now it is easily configurable by JSX composition in (note I've removed some unused codes in Hooks) |
fhammerschmidt
approved these changes
Apr 24, 2024
fhammerschmidt
merged commit 9dcf138
into
rescript-association:master
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top navigation disappears when you scroll down and reappears when you scroll up. Like browsers, and many content services like Medium,
This is a necessary feature for mobile readers with a small viewport.
Also made some code changes here to add memoization, because the scroll event is highly frequant.
React.useStatepreserves the reference of the set dispatcher, but doesn't for the surrounding tuple. Adding a few memo, most children, except for components that are cheap to render, are not re-rendered.Also no deep re-render, the appearance state is propagated via old good CSS cascading rather than React state.