Marshal #6115
Closed
Marshal #6115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
force-pushed
the
untagged_variants
branch
from
ad3e1d8
to
7781a38
Compare
No need for @as(unboxed) anymore. Move type defs around. Unify type definitions for untagged. Add handling of float. Add partial treatment of unknown. wip Clean up names of types. Rename: literal More renaming. rename: Block Handle unknown case. Add Object. Add typeof to body of switch. Complete classification of blocks. Check that the type def is in one of the forms allowed. Fix well-formedness test no other blocks when there's an unknown rename More renaming. Add specific function compile_untagged_cases Add support for array types. Simplify well-formedness check. Add Json example. And add built-in knowledge that Js.Dict.t is an object. Fix instanceof array. flip Fix compilation of unknown. Add untagged variant support to genType. Explore (un)marshaling binary data from the compiler dune build marshal_test.bc.js node ./_build/default/marshal_test.bc.js Explore (un)marshaling binary data from the compiler Expose caml_read_file_content Build up the example to counting elements in a list ``` ocaml gen_aaa.ml node jscomp/test/marshal_test.js ```
|
Closing after discussion with @cristianoc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begin experimenting with marshal/unmarshal native binary data
More context: #6110