Specialize Js.Dict.fromArray to compile to direct JS object creation #6538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about RescriptCore.Dict.fromArray? |
|
Yeah that's a good point, we should make sure this PR handles both. |
|
Dict should be promoted to a built in type and specialized that way instead. |
zth
force-pushed
the
specialize-js-dict-fromArray
branch
from
45b4d6a
to
f67c121
Compare
|
@cristianoc please have a look at whether this approach is good and if the optimization is in the correct place. Maybe it could be put somewhere else? When Core moves into the compiler (#6761) then we'll change this to account for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when possible.
A Dict is obviously a JS object at runtime, but there has been no way to create a dict in a way that compiles to a regular JS object creation. This can be a bit confusing when looking at the generated code, as well as hurt performance (albeit slightly in most cases) as creating dict objects are done dynamically via an array.
This changes so that any
Js.Dict.fromArraycall that is an array with static string keys can get compiled to an actual JS object creation.@cristianoc no idea if this is the right way to go about it, feedback very welcome.
Related issues: