Fix fontWeight again #806
Open
Fix fontWeight again #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
force-pushed
the
fix-font-weight-again
branch
from
87b0cc3
to
b24f019
Compare
fhammerschmidt
previously approved these changes
Mar 4, 2024
cknitt
force-pushed
the
fix-font-weight-again
branch
from
b24f019
to
a134bc7
Compare
cknitt
force-pushed
the
fix-font-weight-again
branch
from
a134bc7
to
239d39a
Compare
fhammerschmidt
approved these changes
Mar 4, 2024
|
@cknitt which version of Number values are accepted since I didn't experience any crash on Android or iOS. |
|
That's weird as I had the crash on Android with 0.73.5. |
|
I'm still on 0.71.14 so maybe there is a regression on this in |
|
I tested it on a 0.73.4 project and it work well on Android, without crashing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #775 again by reverting the
fontWeighttype definition to its pre-#793 state.Unfortunately this is a breaking change yet again. But better than crashes on Android...