Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue329 node 12 #358

Merged
merged 14 commits into from Feb 20, 2020
Merged

Issue329 node 12 #358

merged 14 commits into from Feb 20, 2020

Conversation

jspaaks
Copy link
Member

@jspaaks jspaaks commented Feb 12, 2020

fixes #329

@jspaaks
Copy link
Member Author

jspaaks commented Feb 12, 2020

For some reason, the order of some elements has changed and as a result the admin tests on travis fail because some parts of the snapshots are different than what is being generated.

in part this could be due to some elements in the admin interface having been assigned an equal value for sortIndex, e.g.

"sortIndex": 500,
"help":
"The <a href=\"https://help.zenodo.org/#versioning\">Zenodo concept DOI</a>. Not a URL"
},
"createdAt": {
"label": "Created at",
"sortIndex": 1000,
"readonly": true
},
"createdBy": {
"label": "Created by",
"sortIndex": 1000,
"readonly": true
},
"getStartedURL": {
"label": "Getting started URL",
"sortIndex": 500

This however does not explain the changed order of some of the other elements, e.g. the mentions Maybe related, when building the admin, I got a previously unseen error

warning sha.js@2.4.11: Invalid bin entry for "sha.js" (in "sha.js").

@jspaaks jspaaks marked this pull request as ready for review February 18, 2020 18:23
@sverhoeven
Copy link
Contributor

The order must be due to the Node version iterating through the properties in a different way.

@sverhoeven
Copy link
Contributor

Tried branch and was also able to use the admin interface

@sverhoeven sverhoeven merged commit 5c02e50 into master Feb 20, 2020
@jspaaks jspaaks deleted the issue329-node-12 branch February 20, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Node.js 8 in admin
2 participants