Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Contacts list method #63

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Fix Contacts list method #63

merged 1 commit into from
Jan 17, 2024

Conversation

thedatadavis
Copy link
Contributor

  • Correct the list contacts method
  • Update pointers to API documentation

@thedatadavis
Fix Contacts list method
057906e 
* Correct the `list` contacts method
* Update pointers to API documentation
drish
drish reviewed Jan 17, 2024
View reviewed changes
resend/contacts.py
def list(cls, audience_id) -> Dict:
path = f"/audiences/#{audience_id}/contacts"
path = f"/audiences/{audience_id}/contacts"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @thedatadavis

drish
drish approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@drish drish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the contribution @thedatadavis

@drish drish merged commit 60b715b into resend:main Jan 17, 2024
8 checks passed
@thedatadavis thedatadavis deleted the patch-1 branch January 18, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drish drish drish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thedatadavis @drish