Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS on windows #338

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

TLS on windows #338

wants to merge 5 commits into from

Conversation

renaud-sc
Copy link
Contributor

  • Fix certificate path construction and Windows
  • Fix various typos

@sgodin
Copy link
Member

sgodin commented Oct 27, 2023

Thanks Renaud! I was under the impression that windows doesn't really care if you use / or \ as a path separator. What error were you seeing before this fix?

@renaud-sc
Copy link
Contributor Author

You are right, I must have seen exceptions due to invalid certificates and confused myself.. However I think this improves the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@renaud-sc @sgodin