Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea is to provide the ability to understand from third-party applications which a class method can be used depending on resiprocate library version.
I am upgrading the resiprocate library for my code from version 1.9.2 to master (possibly 1.13.0) and found the issue:
resip::SipMessage::getTransport()
vsresip::SipMessage::getReceivedTransportTuple()
. I think there will be more )The PR changes allows to include the header
<resip/version.h>
header and find the library version by the defined variableRESIPROCATE_VERSION_NUMBER
or functionRESIPROCATE_VERSION_PREREQ(maj, min, patch)
.For example,
Meanwhile, the resiprocate library staff can use the header
<version.h>
with the defined variable HAVE_VERSION_H for any cases where the version number is required.P.S. The idea was borrowed from the OpenSSL library with the definition of OPENSSL_VERSION_NUMBER.