MessageWaitingContents: skip body lines which do not match rfc 3842. #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the line matches /^[fmnptv/i but does not match /^\w+-Message:/ it is skiped. This ignores lines like /^Voicemail: \d+/\d+$/ from before rfc 3842 which some software still send for backward compatibility. Signed-off-by: James Cloos <cloos@jhcloos.com>
|
Hmmm, this isn't quite what I was picturing when I suggested it. I thought you were suggesting to look for the entire header string (case insensitive) instead of just the first letter for all header types. I'm not sure I like the solution you presented. It took me a while to figure out exactly what you were doing here, and the fact that all the headers actually contain the word Message somewhere in them. With the exception of the none type - that I don't believe will work at all now. Can you change this to tokenize the header name first, then do a case insensitve compare (on the full header text) for each accepted type to assign the ht (header type) to it? If the header token is not recognized, then we will can happily ignore it. |
|
Sure.
I kept the current initial letter check presuming that a minimal change
would be preferred.
But I can switch it to a full compare.
…-JimC
--
James Cloos <cloos@jhcloos.com> OpenPGP: 0x997A9F17ED7DAEA6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the line matches /^[fmnptv/i but does not match /^\w+-Message:/
it is skiped.
This ignores lines like /^Voicemail: \d+/\d+$/ from before rfc 3842
which some software still send for backward compatibility.
Signed-off-by: James Cloos cloos@jhcloos.com