This repository has been archived by the owner on Nov 4, 2023. It is now read-only.
fix(CAMERA_STREAM): stream fails to resume after being suspended #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appears to be a regression in v1 of hls.js. An upstream issue created at video-dev/hls.js#3732 But I also found similar issue (video-dev/hls.js#2473) that seems to suggest that it's best to just re-initialize the Hls instance instead of re-attaching the media so I'll just go with that for now. Fixes #688
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appears to be a regression in v1 of hls.js. An upstream issue created
at video-dev/hls.js#3732
But I also found similar issue (video-dev/hls.js#2473)
that seems to suggest that it's best to just re-initialize the Hls
instance instead of re-attaching the media so I'll just go with that
for now.
Fixes #688