Add option to choose to take a screenshot with the device dimensions being the minimum. #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mounir-Bouaiche
changed the title
Mounir-Bouaiche
changed the title
manojVivek
requested changes
Sep 5, 2023
| @@ -148,6 +148,10 @@ const schema = { | |||
| }, | |||
| default: {}, | |||
| }, | |||
| onlyVisibleParts: { | |||
| type: 'boolean', | |||
| default: false, | |||
There was a problem hiding this comment.
Can we make the default as true? So that the current behaviour stays the same unless specifically modified in the settings.
|
|
||
| try { | ||
| if (rect != null) { | ||
| console.log(rect); |
There was a problem hiding this comment.
Can you please remove this debug log line?
| screenShotDelegate.setContentSize(rect.width, rect.height); | ||
| } | ||
| } catch (ex) { | ||
| // |
There was a problem hiding this comment.
Maybe console.log the error here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
📓 Referenced Issue
ℹ️ About the PR
This is useful when you want to take a screenshot with the device dimensions being the minimum.
🖼️ Testing Scenarios / Screenshots
With:
Without: