Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resque::Failure::Multiple calls save to all backends even if some backends fail #1631

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

labocho
Copy link
Contributor

@labocho labocho commented May 29, 2018

When some failure backend raise error during Resque::Failure::Multiple#save, the rest backends' save are never called.

class BrokenBackend < Resque::Failure::Base
  def save
    raise "Broken"
  end
end

Resque::Failure::Multiple.classes = [BrokenBackend, Resque::Failure::Redis]
Resque::Failure.backend = Resque::Failure::Multiple

# When a job fails, Resque::Failure::Redis#save is never called.

I want to call all backends' save for redundancy. I wrote patch to call all backends and wrap original error(s).

@matthewhively
Copy link
Contributor

This would be cool if this could be fixed up and merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants