Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.markdown #1891

Merged
merged 1 commit into from
May 17, 2024
Merged

Update README.markdown #1891

merged 1 commit into from
May 17, 2024

Conversation

danlo
Copy link
Contributor

@danlo danlo commented Dec 5, 2023

Added note about dependency requirement of rack-session 2.0.0 using Rack 3, which sinatra does not support. Suggesting to user that they downgrade to rack-session 1.0.2

Added note about dependency requirement of rack-session 2.0.0 using Rack 3, which sinatra does not support.  Suggesting to user that they downgrade to rack-session 1.0.2
Copy link
Member

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pboling pboling merged commit fa72b7b into resque:master May 17, 2024
88 checks passed
@mishina2228
Copy link
Contributor

@danlo Sinatra 4.0 supports Rack 3.0, so we can use rack-session 2.0 with Rails 7.1.

@pboling
Copy link
Member

pboling commented May 17, 2024

@mishina2228 Excellent! PRs welcome, otherwise, I'll try to get around to re-updating the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants