Issue #1103: mssing fields added and minor cleanup

restfb · Nov 15, 2020 · 638aaf7 · 638aaf7
1 parent b3481cf
commit 638aaf7
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/src/main/java/com/restfb/DefaultFacebookClient.java b/src/main/java/com/restfb/DefaultFacebookClient.java
@@ -304,9 +304,7 @@ public <T> T fetchObjects(List<String> ids, Class<T> objectType, Parameter... pa
 
     // Normalize the IDs
     for (String id : ids) {
-      if (StringUtils.isBlank(id)) {
-        throw new IllegalArgumentException("The list of IDs cannot contain blank strings.");
-      }
+      throwIAEonBlankId(id);
       idArray.add(id.trim());
     }
 
@@ -320,6 +318,12 @@ public <T> T fetchObjects(List<String> ids, Class<T> objectType, Parameter... pa
     }
   }
 
+  private void throwIAEonBlankId(String id) {
+    if (StringUtils.isBlank(id)) {
+      throw new IllegalArgumentException("The list of IDs cannot contain blank strings.");
+    }
+  }
+
   /**
    * @see com.restfb.FacebookClient#publish(java.lang.String, java.lang.Class, com.restfb.BinaryAttachment,
    *      com.restfb.Parameter[])

diff --git a/src/main/lombok/com/restfb/types/ads/AdCreative.java b/src/main/lombok/com/restfb/types/ads/AdCreative.java
@@ -225,6 +225,11 @@ public class AdCreative extends NamedAdsObject {
   @Facebook("instagram_story_id")
   private String instagramStoryId;
 
+  @Getter
+  @Setter
+  @Facebook("instagram_user_id")
+  private String instagramUserId;
+
   @Getter
   @Setter
   @Facebook("interactive_components_spec")
@@ -367,6 +372,11 @@ public class AdCreative extends NamedAdsObject {
   @Facebook("product_set_id")
   private String productSetId;
 
+  @Getter
+  @Setter
+  @Facebook("source_instagram_media_id")
+  private String sourceInstagramMediaId;
+
   /**
    * The run status of this creative.
    *