fix(microservice): remove shell option, npm commands, treekill and handle silent processes #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-go
force-pushed
the
rework-microservice
branch
6 times, most recently
from
4798648
to
81dca28
Compare
tony-go
changed the title
tony-go
changed the title
tony-go
force-pushed
the
rework-microservice
branch
from
81dca28
to
05f6df3
Compare
tony-go
force-pushed
the
rework-microservice
branch
from
cabb7cc
to
f89f261
Compare
|
Hey @olivierodo could you take a look? I'm trying to remove I'd like to keep this PR simple and so I'll update the init step in another PR. |
tony-go
changed the title
tony-go
force-pushed
the
rework-microservice
branch
from
62e604c
to
c29c6a8
Compare
tony-go
force-pushed
the
rework-microservice
branch
from
9e6144f
to
d54b896
Compare
|
I have a few test that fails on CI but not locally, I'll re-run the CI once or try to find it out tomorrow :) |
tony-go
force-pushed
the
rework-microservice
branch
from
f9cc170
to
907a18e
Compare
tony-go
force-pushed
the
rework-microservice
branch
from
907a18e
to
3d898ff
Compare
|
馃帀 |
tony-go
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gains
This PR aims to reduce layers between
restqaand the server we have to spawn.Updates
treekill馃帀* before, we never had to handle it as the npm scripts print the command themselves...