-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect line opacity mapping #296
fix: incorrect line opacity mapping #296
Conversation
current code treats opacity as [0, 100] even though the manpage documents it as being [0, 255]. Fixes: resurrecting-open-source-projects#281
It should fix the issue, but some actual real-world testing is still needed. |
The opacity setting doesn't seem to work in general:
I see no difference between master and this PR, both are broken, the line isn't transparent at all, it does blend oddly with whatever is under it however. Why not just remove it since nobody complained about it not working in all this time? |
Are you running under a compositor that supports Lines 163 to 164 in 6e2b522
It seems to be working fine (except the 100 vs 255 part) for the person that opened the bug report #281:
|
I'm running xcompmgr, seems it doesn't. picom (a fork of xcompmgr) also doesn't it seems. |
Should probably document that it can't be any compositor, too. |
What WM were you running? Perhaps this flag makes it work? |
spectrwm. Still doesn't work with that flag. |
If no one can test this, I'll just merge it in a day or two, since the math adds up. |
95350f6
into
resurrecting-open-source-projects:master
current code treats opacity as [0, 100] even though the manpage documents it as being [0, 255].
Fixes: #281