Improvements to code assist in the REPL #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retronym
force-pushed
the
ticket/12267-completion-matcher
branch
2 times, most recently
from
40e3c01
to
21168b4
Compare
retronym
changed the title
retronym
force-pushed
the
ticket/12267-completion-matcher
branch
2 times, most recently
from
62aedfe
to
beec5db
Compare
sbt 1.4.9 (was 1.4.7)
Allow only protected when overriding Java methods(Correct the test)
Fix regression in ZipArchive
spec private class
REPL: improve tab-completion of `:`-prefixed commands (fixes scala/bug#12264)
Document sign extension in conversion to int for purposes of enrichment. Similarly for toOctalString and toBinaryString.
add testing for status quo of Byte and Short toHexString
allow $ escaping double quotes in interpolations under -Xsource:3
Changing `"Hello, \"World\""` to `s"Hello, \"$who\""` no longer breaks.
Before this change, `\"` terminated single-quoted interpolated string
literals, now the string remains open. The scanner doesn't interpret
the escape sequence, string interpolators can do so (`s` and `f` do).
Breaking changes:
- `raw"c:\"` no longer compiles, it's now an unclosed string
- `raw"c:\" // uh"` used to evaluate to `"""c:\"""`, now it's
`"""c:\" // uh"""`
Also, unicode escapes are no longer interpreted in interpolated strings. Interpolators can still interpret them, but that's not in the spec.
(now that it's possible to do so, after scala#9463) In this case of e.g. `implicitNotFound`, this makes it clearer that the custom error message must be a literal value. Fixes scala#10424 Co-authored-by: Seth Tisue <seth@tisue.net>
Typo in test
The issue here was that in order to replace a Scala 3 macro with a matching Scala 2 macro we have to wait until we have seen all definitions in the scope - before this PR, only Scala 3 macros were considered for eviction, now all inline methods are.
Require less stack compiling 150 field case class (with a balanced AND)
|
Rebased. Updated to the new release of JLine which I've been waiting for. TODO: |
retronym
changed the title
Handle Scala 3 star in import braces
Adapted multiarg infix is just a tuple
No protected accessor when accessing through self type
Check that varargs is applied only to methods
Regression test for varargs and seq override
sbt 1.5.3 (was 1.5.2)
Substitute both type and value parameter symbols in return type
Fix specialization of methods with dependent return types
Fix `ArrayOps` bugs (by avoiding using `ArraySeq#array`, which does not guarantee element type)
retronym
force-pushed
the
ticket/12267-completion-matcher
branch
3 times, most recently
from
d2386d1
to
4e1a4d1
Compare
Re-enable acronmyn-style completion, e.g. getClass.gdm` offers `getDeclaredMethod[s]`. Disable the typo-matcher in JLine which tends to offer confusing Fix completion of keywored-starting-idents (e.g. `this.for<TAB>` offers `formatted`. Register a widget on CTRL-SHIFT-T that prints the type of the expression at the cursor. A second invokation prints the desugared AST. REPL completion - Enable levenstien based typo matching ``` scala> scala.tools.nsc.util.EditDistance.levenshtien<TAB> scala> scala.tools.nsc.util.EditDistance.levenshtein<TAB> ```
retronym
force-pushed
the
ticket/12267-completion-matcher
branch
from
4e1a4d1
to
85e7a41
Compare
|
Upstream PR: scala#9656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable acronym-style completion, e.g. getClass.gdm
offersgetDeclaredMethod[s]`.Under JLine completion, move all filtering up in the UI layer.
Reimplement scala#9510 (dealing with overloads that contain some
deprecated alternatives) in the UI layer
Fix completion of keyword-starting-idents (e.g.
this.for<TAB>offersformatted.Register a widget on CTRL-SHIFT-T that prints the type of the
expression at the cursor. A second invokation prints the
desugared AST.
Enable levenstien based typo matching, but disable it for short strings
which IMO tends to offer confusing results.
Enable levenstien based typo matching: