Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitattributes #720

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

smorimoto
Copy link
Contributor

No description provided.

@Et7f3
Copy link
Member

Et7f3 commented Jan 18, 2020

Which rei file is not marked as reason interface ? and we have some .re file that are marked as c++ so I don't think it is the right fix.

@smorimoto
Copy link
Contributor Author

Linguist related changes take some time. Also, basically I should have changed re and rei at the same time in the previous PR, but I forgot about that so I updated it this time. (Even if it's correct at the moment, it's not a bad idea to force it in advance for the future.)

@Et7f3
Copy link
Member

Et7f3 commented Jan 18, 2020

It was merged 4 days ago 👀 (it shouldn't be that long). I will wait .re file are marked as reason before merge.

@smorimoto
Copy link
Contributor Author

Just out of curiosity, which code is marked as C++?

@Et7f3
Copy link
Member

Et7f3 commented Jan 19, 2020

@CrossR
Copy link
Member

CrossR commented Jan 19, 2020

I can at least confirm that when running linguist locally, the previous PR did fix the issue.

Before the previous PR:

image

After:

image

It must just be taking a while?

All the files that GitHub says are C++ are classed as Reason locally now.

@smorimoto
Copy link
Contributor Author

This was relatively quick for a small project, but it can take a while for a project of this size.

@Et7f3
Copy link
Member

Et7f3 commented Jan 20, 2020

@CrossR Is there some files with wrong language or we can merge.

@CrossR
Copy link
Member

CrossR commented Jan 20, 2020

I didn't see any Reason files that were being picked up as C++, or anything other than Reason from my look over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants