Merge pull request #171 from reviewdog/fix-eslint-warnings-2021-11-09

Fix eslint warnings 2021 11 09

.eslintrc.json

@@ -13,6 +13,7 @@
         "project": "./tsconfig.json"
     },
     "rules": {
+        "i18n-text/no-en": "off",
         "eslint-comments/no-use": "off",
         "import/no-namespace": "off",
         "no-unused-vars": "off",
@@ -45,6 +46,7 @@
         "@typescript-eslint/no-extraneous-class": "error",
         "@typescript-eslint/no-for-in-array": "error",
         "@typescript-eslint/no-inferrable-types": "error",
+        "@typescript-eslint/no-floating-promises": "error",
         "@typescript-eslint/no-misused-new": "error",
         "@typescript-eslint/no-namespace": "error",
         "@typescript-eslint/no-non-null-assertion": "warn",
@@ -59,11 +61,6 @@
         "@typescript-eslint/promise-function-async": "error",
         "@typescript-eslint/require-array-sort-compare": "error",
         "@typescript-eslint/restrict-plus-operands": "error",
-        "semi": "off",
-        "@typescript-eslint/semi": [
-            "error",
-            "always"
-        ],
         "@typescript-eslint/type-annotation-spacing": "error",
         "@typescript-eslint/unbound-method": "error"
     },

.github/workflows/reviewdog.yml

@@ -163,3 +163,19 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - uses: reviewdog/action-actionlint@v1
+
+  eslint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+
+      - uses: actions/setup-node@v2
+        with:
+          node-version: "12"
+          cache: 'npm'
+      - run: npm ci
+      - uses: reviewdog/action-eslint@v1
+        with:
+          reporter: github-pr-review
+          level: warning
+          eslint_flags: "src/**/*.ts"

__test__/installer.test.ts

@@ -33,11 +33,11 @@ describe('installer', () => {
     const dir = await fs.mkdtemp(path.join(tempDir, 'golangci-'));
     const golangci = await installer.installGolangciLint('v1.41.1', dir);
     await exec.exec(golangci, ['--version']);
-  }, 10000);
+  }, 20000);
 
   it('installs the latest version of golangci-lint', async () => {
     const dir = await fs.mkdtemp(path.join(tempDir, 'golangci-'));
     const golangci = await installer.installGolangciLint('latest', dir);
     await exec.exec(golangci, ['--version']);
-  }, 10000);
+  }, 20000);
 });