Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add go_version_file input #389

Merged
merged 1 commit into from Aug 14, 2022

Conversation

upamune
Copy link
Member

@upamune upamune commented Aug 12, 2022

WHAT

I've added a go_version_file input similar to actions/setup-go@v3 . https://github.com/actions/setup-go#getting-go-version-from-the-gomod-file

WHY

Since setup-go now reads the Go version from the file, I would appreciate it if this action is also supported so I don't have to write the Go version to $GITHUB_ENV.

Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks

@shogo82148 shogo82148 merged commit 99a63a1 into reviewdog:master Aug 14, 2022
@review-dog
Copy link
Member

Hi, @upamune! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants