Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order inputs alphabetically #102

Merged
merged 3 commits into from May 15, 2024
Merged

Order inputs alphabetically #102

merged 3 commits into from May 15, 2024

Conversation

toy
Copy link
Contributor

@toy toy commented May 2, 2024

Order inputs alphabetically, to easily find relevant option and know where to insert a new one

@toy toy mentioned this pull request May 2, 2024
Open
@javierjulio javierjulio self-requested a review May 6, 2024 17:17
javierjulio
javierjulio approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We do have many inputs so this should help. I'm good with the change. If no objections, then I'll merge.

@toy
Copy link
Contributor Author

toy commented May 13, 2024

@javierjulio Truing to nudge about this PR and about #103

javierjulio
javierjulio approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@toy @javierjulio
Better wording in comments requesting to maintain alphabetical order …
60a111f 
…of inputs

Co-authored-by: Javier Julio <javierjulio@icloud.com>
@javierjulio javierjulio merged commit 6c175bc into reviewdog:master May 15, 2024
5 checks passed
@review-dog
Copy link
Member

Hi, @toy! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!

@toy toy deleted the order branch May 15, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierjulio javierjulio javierjulio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toy @review-dog @javierjulio